-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
feat(jest-config): add defineConfig
and mergeConfig
functions
#15844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
babel-jest
babel-plugin-jest-hoist
babel-preset-jest
create-jest
@jest/diff-sequences
expect
@jest/expect-utils
jest
jest-changed-files
jest-circus
jest-cli
jest-config
@jest/console
@jest/core
@jest/create-cache-key-function
jest-diff
jest-docblock
jest-each
@jest/environment
jest-environment-jsdom
@jest/environment-jsdom-abstract
jest-environment-node
@jest/expect
@jest/fake-timers
@jest/get-type
@jest/globals
jest-haste-map
jest-jasmine2
jest-leak-detector
jest-matcher-utils
jest-message-util
jest-mock
@jest/pattern
jest-phabricator
jest-regex-util
@jest/reporters
jest-resolve
jest-resolve-dependencies
jest-runner
jest-runtime
@jest/schemas
jest-snapshot
@jest/snapshot-utils
@jest/source-map
@jest/test-result
@jest/test-sequencer
@jest/transform
@jest/types
jest-util
jest-validate
jest-watcher
jest-worker
pretty-format
commit: |
3496223
to
565fc14
Compare
To start Jest doc, we need to run `fetchSupporters` first otherwise it's not possible to start doc server
565fc14
to
4f7105c
Compare
defineConfig
and mergeConfig
functionsdefineConfig
and mergeConfig
functions
Yes, love this! I actually thought about this yesterday after seeing ESLint has added the same 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
"scripts": { | ||
"start": "docusaurus start", | ||
"website:start": "yarn start", | ||
"start": "yarn fetchSupporters && docusaurus start", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed when doing a fresh checkout of Jest repo and start the documentation, doc server will fail because it needs to have supporters to be available on disk so dev server can pick up.
It took me some time to figure out this issue. Therefore adding this to start
command would help
Summary
Inspired from Vite and Playwright, this PR introduces 2 new functions to
jest-config
:defineConfig
andmergeConfig
.This will greatly improve DX that developers:
Test plan